Re: [PATCH v8 08/14] drm/bridge: it6505: avoid division by zero in audio FS debug print

From: Daniel Golle

Date: Mon Nov 16 2026 - 03:56:42 EST


Hi Luca,

On Tue, Oct 20, 2026 at 06:51:39PM +0200, Luca Ceresoli wrote:
> By just looking at your patch and the current driver code I'm failing to
> understand what's going on with the REG_AUDIO_INPUT_FREQ register:
>
> * it is read, but never written
> * its value is used by:
> - it6505_enable_audio() only for logging: is that logging really useful?
> - it6505_audio_input(), just checking whether it is 0xFF or not; what's
> that 0xFF? Is it documented? A macro hinting at what 0xFF means would
> be better than just '0xFF'
>
> If you could share what that register is for, it would probably answer some
> of those questions.

I don't have documentation for it either, and with ITE gone there is
nobody left to ask. Judging from the debug print, which computes the
sample rate as 6750 / regbe kHz, it is a read-only measurement of the
audio sample period, and 0xff looks like the counter saturating when
no audio clock is present.

As for the logging, I don't think it is worth an extra i2c read and a
division in the enable path, so in v9 I'll drop the read and the
print from it6505_enable_audio() instead of guarding the division.
Without documentation I'd rather not invent a name for 0xff and leave
it6505_audio_input() as it is.

Cheers

Daniel