Re: [PATCH v5 11/13] drm/bridge: tc358762: Drop drm_bridge_funcs.mode_set

From: Andreas Kemnade

Date: Mon Nov 16 2026 - 04:06:54 EST


On Thu, 15 Oct 2026 14:16:02 +0300
Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx> wrote:

> drm_bridge_funcs.mode_set is deprecated. Drop it and get the
> drm_display_mode from the atomic state.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>
Reviewed-by: Andreas Kemnade <andreas@xxxxxxxxxxxx>
> ---
> drivers/gpu/drm/bridge/tc358762.c | 26 ++++++++++++--------------
> 1 file changed, 12 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc358762.c
> index a91cf159ba27..33312300e606 100644
> --- a/drivers/gpu/drm/bridge/tc358762.c
> +++ b/drivers/gpu/drm/bridge/tc358762.c
> @@ -98,7 +98,6 @@ struct tc358762 {
> struct regulator *regulator;
> struct drm_bridge *panel_bridge;
> struct gpio_desc *reset_gpio;
> - struct drm_display_mode mode;
> bool pre_enabled;
> int error;
> bool use_vtg;
> @@ -186,9 +185,18 @@ static void tc358762_enable(struct drm_bridge *bridge,
> struct drm_atomic_commit *state)
> {
> struct tc358762 *ctx = bridge_to_tc358762(bridge);
> + struct drm_connector_state *conn_state;
> + struct drm_crtc_state *crtc_state;
> + struct drm_connector *connector;
> + struct drm_display_mode *mode;
> u32 lcdctrl;
> int ret;
>
> + connector = drm_atomic_get_new_connector_for_encoder(state, bridge->encoder);
> + conn_state = drm_atomic_get_new_connector_state(state, connector);
> + crtc_state = drm_atomic_get_new_crtc_state(state, conn_state->crtc);
> + mode = &crtc_state->mode;
> +
> /*
> * DPIENABLE has reset default of 1. Make sure we don't output on
> * DPI until we have finished the coniguration.
> @@ -213,7 +221,7 @@ static void tc358762_enable(struct drm_bridge *bridge,
> if (ctx->use_vtg) {
> struct videomode vm = { 0 };
>
> - drm_display_mode_to_videomode(&ctx->mode, &vm);
> + drm_display_mode_to_videomode(mode, &vm);
>
> tc358762_write(ctx, LCDC_HSR_HBPR,
> vm.hsync_len | (vm.hback_porch << 16));
> @@ -237,10 +245,10 @@ static void tc358762_enable(struct drm_bridge *bridge,
>
> lcdctrl |= LCDCTRL_DCLK_POL;
>
> - if (ctx->mode.flags & DRM_MODE_FLAG_PHSYNC)
> + if (mode->flags & DRM_MODE_FLAG_PHSYNC)
> lcdctrl |= LCDCTRL_HSYNC_POL;
>
> - if (ctx->mode.flags & DRM_MODE_FLAG_PVSYNC)
> + if (mode->flags & DRM_MODE_FLAG_PVSYNC)
> lcdctrl |= LCDCTRL_VSYNC_POL;
>
> tc358762_write(ctx, LCDCTRL, lcdctrl);
> @@ -265,15 +273,6 @@ static int tc358762_attach(struct drm_bridge *bridge,
> bridge, flags);
> }
>
> -static void tc358762_bridge_mode_set(struct drm_bridge *bridge,
> - const struct drm_display_mode *mode,
> - const struct drm_display_mode *adj)
> -{
> - struct tc358762 *ctx = bridge_to_tc358762(bridge);
> -
> - drm_mode_copy(&ctx->mode, mode);
> -}
> -
> static const struct drm_bridge_funcs tc358762_bridge_funcs = {
> .atomic_post_disable = tc358762_post_disable,
> .atomic_pre_enable = tc358762_pre_enable,
> @@ -282,7 +281,6 @@ static const struct drm_bridge_funcs tc358762_bridge_funcs = {
> .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
> .atomic_create_state = drm_atomic_helper_bridge_create_state,
> .attach = tc358762_attach,
> - .mode_set = tc358762_bridge_mode_set,
> };
>
> static int tc358762_parse_dt(struct tc358762 *ctx)
>