Re: RE: RE: [PATCH can 4/4] can: rcar_canfd: rcar_canfd_probe(): reject devices without match data

From: Marc Kleine-Budde

Date: Mon Nov 16 2026 - 04:20:29 EST


On 16.11.2026 09:12:13, Biju Das wrote:
> > Thanks, I wasn't aware of this series. I tested the driver_override on the flexcan driver with latest
> > net/main, fixed it, and applied the fix to all affected CAN drivers.
> >
> > Should I drop the driver_override related null pointer checks from this series?
>
> I think so, currently only few drivers are using driver_override feature and
> majority don't. There is a work in progress to disable this feature by
> default. The driver needs driver_override will adjust the probe() to make it
> functional, so it won't fail at all in probe().
>
> But here we are making probe to fail,

Without my patch, using driver_override the info pointer is NULL and it
will crash 5 lines later with a NULL pointer dereference.

> in case someone wants to
> test the driver using bus_override.
^^^^^^^^^^^^
What's bus_override?

Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |

Attachment: signature.asc
Description: PGP signature