Re: [PATCH] usb: r8a66597-hcd: Fix clock leak and unchecked clk_prepare_enable()
From: Greg Kroah-Hartman
Date: Mon Nov 16 2026 - 04:34:31 EST
On Mon, Nov 16, 2026 at 11:10:43AM +0800, Xiangwu Lai wrote:
> Hi,
>
> gentle ping for:
>
> usb: r8a66597-hcd: Fix clock leak and unchecked clk_prepare_enable()
> https://lore.kernel.org/all/20261102100455.600-1-laixiangwu@xxxxxxxxxxxxxxxxxxxx/
>
> On on-chip configurations r8a66597_clock_enable() ignores the return
> value of clk_prepare_enable(), and if the subsequent register access
> times out the function returns -ENXIO without disabling the clock
> again. The patch checks the return value and disables the clock on
> the error path.
And are you hitting this in a real system, or is this just a theoretical
issue?
thanks,
greg k-h