[PATCH RFC v3 6/6] PCI: rockchip-host: Mask the client correctable error interrupt
From: Matt Thompson via B4 Relay
Date: Mon Nov 16 2026 - 04:35:58 EST
From: Matt Thompson <matt@xxxxxxxxxxxxx>
On RockPro64 the PCIe client correctable-error bit stayed asserted
during link bring-up despite acknowledgment. Its level interrupt
fired at roughly one million interrupts per second on CPU 0 and
starved RCU.
Mask the controller-local notification, which the driver only uses
for a debug message. Standard PCIe AER uses root port status and its
separate interrupt.
Signed-off-by: Matt Thompson <matt@xxxxxxxxxxxxx>
---
drivers/pci/controller/pcie-rockchip-host.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/controller/pcie-rockchip-host.c
index d6c494f..a8c2575 100644
--- a/drivers/pci/controller/pcie-rockchip-host.c
+++ b/drivers/pci/controller/pcie-rockchip-host.c
@@ -746,8 +746,14 @@ err_out:
static void rockchip_pcie_enable_interrupts(struct rockchip_pcie *rockchip)
{
- rockchip_pcie_write(rockchip, (PCIE_CLIENT_INT_CLI << 16) &
- (~PCIE_CLIENT_INT_CLI), PCIE_CLIENT_INT_MASK);
+ /*
+ * Leave the client correctable-error notification masked. On RK3399
+ * it can remain asserted after acknowledgment during link bring-up
+ * and monopolize the CPU. PCIe AER uses the root port's own status
+ * and interrupt, which are independent of this client mask.
+ */
+ rockchip_pcie_write(rockchip, (PCIE_CLIENT_INT_CLI << 16) |
+ PCIE_CLIENT_INT_CORR_ERR, PCIE_CLIENT_INT_MASK);
rockchip_pcie_write(rockchip, (u32)(~PCIE_CORE_INT),
PCIE_CORE_INT_MASK);
--
Git-155)