Re: [PATCH v2 1/3] i2c: mt7621: assert and deassert the reset line
From: Philipp Zabel
Date: Mon Nov 16 2026 - 04:58:38 EST
On Do, 2026-11-12 at 19:58 +0100, John Crispin wrote:
> The driver resets the controller with device_reset(), which needs a
> .reset operation in the reset controller. The EN7581 reset controller
> implements assert and deassert only, so there every call fails, logs
> "I2C reset failed!" and leaves the controller as it is, also after a
> transfer timeout.
>
> Get the optional reset line at probe and assert and deassert it. The
> MT7621 and MT7628 reset controller does the same in its .reset
> operation, with no delay in between, so nothing changes there. A board
> without a reset line no longer logs an error, and a reset controller
> that is not ready yet defers the probe.
>
> Suggested-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> Signed-off-by: John Crispin <john@xxxxxxxxxxx>
Reviewed-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
regards
Philipp