Re: [PATCH v6 3/9] phy: rockchip-samsung-dcphy: Unwind power-on on PLL lock failure

From: Michael Riesch

Date: Mon Nov 16 2026 - 05:01:31 EST


Hi Jason,

On 11/16/26 04:01, 楊智成 wrote:
> Hi Michael,
>
> On 11/11/26 14:02, Michael Riesch wrote:
>> I wonder whether this should be here in the first place. Only judging by
>> the name, samsung_mipi_dcphy_pll_enable is something that affects the
>> complete logic block and probably should be kept in runtime resume to
>> begin with.
>>
>> However, since _dphy_rx_power_on does not call this funcion, it seems to
>> be something related only to the TX side of the logic block, but for
>> D-PHY and C-PHY. In this case, it probably should go into
>> samsung_mipi_dcphy_tx_power_on.
>>
>> On the off chance that this is actually for the D-PHY TX operation, the
>> function should be renamed "*_dcphy_pll_*" -> "*_dphy_pll_*" or
>> "*_dphy_tx_pll_*".
>>
>> What do you think?
>
> The settings in this function are indeed only for TX, for both D-PHY
> and C-PHY, so I will rename the PLL helpers to
> samsung_mipi_dcphy_tx_pll_* in the renaming patch (6/9).
>
> samsung_mipi_dcphy_tx_power_on does look like a more suitable place.
> However, I do not have a C-PHY board, and I only have one panel with
> mainline support, so I may not be able to test the DC-PHY TX side
> thoroughly. For now I am trying to leave the TX code unchanged unless
> my series affects that code.
>
> Should I move the PLL enable to samsung_mipi_dcphy_tx_power_on, or keep
> this error cleanup path and the renaming change for now?

Thanks for the clarification.

I take it that the patch is only here because sashiko complained about
some existing bug. Your patch fixes this as-is, therefore

Reviewed-by: Michael Riesch <michael.riesch@xxxxxxxxxxxxx>

Still what we discussed makes sense, so let us do some refactoring in a
later series. I don't have any board with display either, but I think
Heiko and Quentin might have one for testing.

But again, let's focus on getting your patch series merged first.

Best regards,
Michael


> Thanks,
> Jason