Re: [PATCH 1/3] dt-bindings: pwm: qcom: add Shikra PWM controller
From: Krzysztof Kozlowski
Date: Mon Nov 16 2026 - 05:05:30 EST
On Mon, Nov 16, 2026 at 12:29:48PM +0530, Taniya Das wrote:
> +patternProperties:
> + "^pwm@[0-9a-f]+$":
> + type: object
> + description: Per-frame PWM channel sub-node.
I don't get the need for the children. The the parent has pwm-cells, so
it should be enough.
> +
> + properties:
> + reg:
> + maxItems: 1
> + description: This frame's own absolute register range.
> +
> + qcom,frame-index:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + Hardware frame index within the PWM block. It is the PWM index
> + used in the first cell of a consumer PWM specifier and selects
> + the corresponding enable bit in PWM_TOPCTL0.
And this seems to be duplicating the value passed through phandle/pwm-cells.
> + maximum: 9
Best regards,
Krzysztof