Re: [PATCH v2 04/14] mm/mm_init: factor out common struct page initialization

From: Mike Rapoport

Date: Mon Nov 16 2026 - 05:43:09 EST


Hi,

> Several struct page fields have the same initial values for every page in
> a zone. __init_single_page() initializes this state as part of its
> per-page setup, while the shared vmemmap tail path open-codes only a
> subset.
>
> Factor the PFN-independent state into memmap_init_page_common() and use
> it for both regular and shared tail struct pages. Keep section-, PFN-
> and instance-specific initialization in __init_single_page().
>
> This also initializes the last cpupid and KASAN tag for shared tail
> struct pages consistently with regular struct pages.
>
> Signed-off-by: Muchun Song <songmuchun@xxxxxxxxxxxxx>
> ---
> v2:
> - Remove __meminit from memmap_init_page_common() so HVO shared tail
> pages can call it after init text is freed (reported by Sashiko).
> ---
> include/linux/mm.h | 8 --------
> mm/mm_init.c | 22 +++++++++++++++++-----
> mm/mm_init.h | 1 +
> mm/sparse-vmemmap.c | 7 +------
> 4 files changed, 19 insertions(+), 19 deletions(-)
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 77b5d450fe45b..2e182498898ec 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -3022,14 +3022,6 @@ static inline void set_page_node(struct page *page, unsigned long node)
> page->flags.f |= (node & NODES_MASK) << NODES_PGSHIFT;
> }
>
> -static inline void set_page_links(struct page *page, enum zone_type zone,
> - unsigned long node, unsigned long pfn)
> -{
> - set_page_zone(page, zone);
> - set_page_node(page, node);
> - set_page_section_from_pfn(page, pfn);
> -}
> -
> /**
> * folio_nr_pages - The number of pages in the folio.
> * @folio: The folio.
> diff --git a/mm/mm_init.c b/mm/mm_init.c
> index af3b81733193b..d0a11989bd249 100644
> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -602,15 +602,27 @@ static inline void vmemmap_optimization_verify_zone(struct page *page)
> page_zone_id(page));
> }
>
> -void __meminit __init_single_page(struct page *page, unsigned long pfn,
> - unsigned long zone, int nid)
> +/* Initialize PFN-independent fields common to pages in the same zone. */
> +void memmap_init_page_common(struct page *page, enum zone_type zone, int nid)

I don't think _common adds much here, memmap_init_page() would do.

> {
> mm_zero_struct_page(page);
> - set_page_links(page, zone, nid, pfn);
> - init_page_count(page);
> - atomic_set(&page->_mapcount, -1);
> + set_page_zone(page, zone);
> + set_page_node(page, nid);
> page_cpupid_reset_last(page);
> page_kasan_tag_reset(page);
> + atomic_set(&page->_mapcount, -1);
> +#ifdef CONFIG_ZONE_DEVICE
> + if (zone == ZONE_DEVICE)
> + __SetPageReserved(page);
> +#endif

Can't we keep this in ZONE_DEVICE part?

If we can't, __init_single_page() sets PG_reserved for ZONE_DEVICE pages
and the

if (zone == ZONE_DEVICE)
__SetPageReserved(page);

in the MEMINIT_HOTPLUG part of memmap_init_range() becomes redundant.

--
Sincerely yours,
Mike.