Re: [PATCH] PCI: Add quirk to mask ACSViol on XHCI on iMac20,1 And iMac20,2

From: Lukas Wunner

Date: Mon Nov 16 2026 - 05:46:32 EST


On Sun, Nov 15, 2026 at 08:08:33PM -0500, Atharva Tiwari wrote:
> On iMac20,1 and iMac20,2 the Thunderbolt xHCI (8086:15ec) triggers an ACS
> Violation on its upstream port whenever it is runtime-resumed from D3hot,
> e.g. on suspend and shutdown:
[...]
> +++ b/arch/x86/pci/fixup.c
[...]
> +static void titan_ridge_xhci_mask_acsv(struct pci_dev *pdev)
> +{
> + struct pci_dev *up = pci_upstream_bridge(pdev);
> +
> + if (!dmi_match(DMI_PRODUCT_NAME, "iMac20,1") &&
> + !dmi_match(DMI_PRODUCT_NAME, "iMac20,2"))
> + return;
> + if (up && up->aer_cap)
> + pci_clear_and_set_config_dword(up, up->aer_cap + PCI_ERR_UNCOR_MASK,
> + 0, PCI_ERR_UNC_ACSV);
> +}

See this discussion:

https://lore.kernel.org/r/CAL0aDZ_HOq1Sof90GJoBDzPo7Gmr7P_rSnYJaN75QH4K+iodpw@xxxxxxxxxxxxxx/

It's an LTR message with a zero Requester ID. This needs to be fixed
more generically, not with a model-specific quirk.

Thanks,

Lukas