Re: [PATCH] wifi: brcmfmac: reload the firmware after a missing D3 ACK

From: Arend van Spriel

Date: Mon Nov 16 2026 - 06:29:04 EST


On Wed, 4 Nov 2026 16:16:16 +0100, Andre Eikmeyer <dev@deq.rocks> wrote:
> Since commit 6f88e6ebdc1a ("wifi: brcmfmac: Improve D3 substate entering
> timeout handling") system suspend goes on after a missing D3 ACK when
> WoWL is off. On resume brcmf_pcie_pm_leave_D3() still takes the hot
> resume path when the INTMASK register reads back nonzero. Firmware that
> did not answer D3_INFORM can do that and stays dead afterwards.
>
> [...]
>
> Record the missing ACK and force the remove and re-probe path on the
> next resume so the firmware is loaded again.
>
> brcmf_msgbuf_delete_flowring() waits for outstanding tx status before
> it checks the bus state. Check the bus first and stop waiting when it
> goes down, since the firmware does not report tx status then.
>
> Fixes: 6f88e6ebdc1a ("wifi: brcmfmac: Improve D3 substate entering timeout handling")
> ---
> .../broadcom/brcm80211/brcmfmac/msgbuf.c | 22 ++++++++++++-------
> .../broadcom/brcm80211/brcmfmac/pcie.c | 16 ++++++++++++++
> 2 files changed, 30 insertions(+), 8 deletions(-)

Thanks for the patch. The resume problem is addressed by Andre Eikmeyer's
series "wifi: brcmfmac: pcie: S3 and deep sleep on the T2 Mac chips" [1]:

- Patch 3/5 ("probe again after a resume through firmware") sends
brcmf_pcie_pm_leave_D3() straight to the remove and re-probe path when
the platform firmware handled the resume and WoWL is off, before the
INTMASK check that lets a dead firmware take the hot resume path.
- Patch 4/5 ("send the flowring delete without waiting for tx status")
removes the tx status wait in brcmf_msgbuf_delete_flowring() that stalls
the flowring teardown when the firmware is gone.

Your patch forces the re-probe on any missed D3 ACK for every PCIe chip,
which also hits firmware that never ACKs D3_INFORM when idle, such as
BCM43752 behind 6f88e6ebdc1a, and logs an error for an expected case. Note
that the msgbuf.c change is a separate change from the D3 ACK handling as
well.

Please test with that series applied. If a case remains where a missed D3
ACK leaves the firmware dead, send a patch on top of it, limited to the
affected chips, with a description of the failure.

[1] https://patchwork.kernel.org/project/linux-wireless/list/?series=1208304

Regards,
Arend