Re: [PATCH v2] ALSA: compress: Set metadata_set only after successful callback

From: Takashi Iwai

Date: Mon Nov 16 2026 - 06:30:14 EST


On Fri, 13 Nov 2026 10:25:59 +0100,
Sreeraj S Kurup wrote:
>
> Set the metadata_set flag only when the driver's set_metadata()
> callback completes successfully.
>
> Previously, the flag was set even when the callback returned an
> error. This incorrectly indicated that metadata had been applied
> successfully, potentially causing later operations to skip metadata
> setup.
>
> Update the flag only when the callback returns zero so that its
> state accurately reflects successful metadata submission.
>
> Fixes: 9727b490e543 ("ALSA: compress: add support for gapless playback")
> Signed-off-by: Sreeraj S Kurup <sreekuttan2156239@xxxxxxxxx>

Applied now. Thanks.


Takashi