Re: [PATCH 5/5] platform/x86: dell: dcdbas: Use read_poll_timeout_atomic() for the type 1 SMI
From: Andy Shevchenko
Date: Mon Nov 16 2026 - 06:44:18 EST
On Fri, Nov 13, 2026 at 10:17:58PM -0800, Rosen Penev wrote:
> For SMI type 1, host_control_smi() polls the APM status port in a loop
> that counts down TIMEOUT_USEC_SHORT_SEMA_BLOCKING iterations and relies
> on each inb() taking about a microsecond. Use
> read_poll_timeout_atomic() with a 1us delay instead, like the type 2
> and 3 path, so the timeout is in microseconds and does not depend on
> how long a port read takes. With the delay plus the port read, the
> worst-case wait grows from about 10ms to about 20ms, which only matters
> when the BIOS never answers.
>
> This removes the last users of num_ticks and EXPIRED_TIMER.
This should be united with the other patch I mentioned before.
--
With Best Regards,
Andy Shevchenko