Re: [PATCH v2 2/2] gpu: nova-core: use pin-init self-referential support
From: Gary Guo
Date: Mon Nov 16 2026 - 06:53:12 EST
On Mon Nov 16, 2026 at 7:56 AM GMT, Alexandre Courbot wrote:
> On Thu Nov 12, 2026 at 1:19 AM JST, Danilo Krummrich wrote:
> <...>
>> drivers/gpu/nova-core/gsp/cmdq.rs | 16 ++++++--
>> drivers/gpu/nova-core/gsp/cmdq/gmc.rs | 9 +++--
>> drivers/gpu/nova-core/gsp/cmdq/rpc.rs | 11 +++---
>
> The changes to these files look like they are a change on their own;
> they are not using the self-referential support but rather change how
> the queue lock is acquired. It should probably be a separate patch
> before the rest (which would be the last patch of the series).
This is actually integral due to variances, as the existing code more or less
relies on cmdq being covariant unsafely. Pin-init is going to enforce that so it
needs to be updated to use existential lifetime to make cmdq actually covariant.
Best,
Gary