[PATCH v3] PCI/ACPI: Initialize the handle in acpi_get_rc_resources()

From: lirongqing

Date: Mon Nov 16 2026 - 07:07:47 EST


From: Li RongQing <lirongqing@xxxxxxxxx>

acpi_get_devices() returns AE_OK even when the namespace walk finishes
without a match; in that case its return_value argument is not written,
because it is only updated when a match terminates the walk early. The
caller passes an uninitialized acpi_handle, so on the no-match path a
stale stack value is handed to acpi_fetch_acpi_dev(), which treats it as
an ACPI namespace node: acpi_get_data_full() rejects a NULL handle up
front, but the garbage value passes through and is dereferenced in
acpi_ns_validate_handle(), which may crash or yield a bogus acpi_device.

Initialize the handle to NULL. A missing match then makes
acpi_fetch_acpi_dev() return NULL, and the existing NULL check on the
returned acpi_device turns it into -ENODEV as intended.

Fixes: 169de969c018 ("PCI/ACPI: Provide acpi_get_rc_resources() for ARM64 platform")
Signed-off-by: Li RongQing <lirongqing@xxxxxxxxx>
---
Diff with v2: remove check if handle is NULL
Diff with v1: add fix tag
drivers/pci/pci-acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
index e260089..f14f74d 100644
--- a/drivers/pci/pci-acpi.c
+++ b/drivers/pci/pci-acpi.c
@@ -82,7 +82,7 @@ int acpi_get_rc_resources(struct device *dev, const char *hid, u16 segment,
{
struct acpi_device *adev;
acpi_status status;
- acpi_handle handle;
+ acpi_handle handle = NULL;
int ret;

status = acpi_get_devices(hid, acpi_match_rc, &segment, &handle);
--
2.9.4