Re: [PATCH v2 1/2] dt-bindings: iio: chemical: Add Sensirion SGP41 binding
From: Krzysztof Kozlowski
Date: Mon Nov 16 2026 - 07:28:48 EST
On Sun, Nov 15, 2026 at 11:29:39AM +0530, Akshat Chandra wrote:
> Add a Device Tree binding for the Sensirion SGP41 VOC and NOx gas
> sensor, including its VDD supply.
>
Few nits except Sashiko comments:
A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst#L23
> Signed-off-by: Akshat Chandra <notmissinge@xxxxxxxxx>
> ---
> .../iio/chemical/sensirion,sgp41.yaml | 43 +++++++++++++++++++
> 1 file changed, 43 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/chemical/sensirion,sgp41.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/chemical/sensirion,sgp41.yaml b/Documentation/devicetree/bindings/iio/chemical/sensirion,sgp41.yaml
> new file mode 100644
> index 000000000000..28528a695cf3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/chemical/sensirion,sgp41.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/chemical/sensirion,sgp41.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sensirion SGP41 VOC and NOx gas sensor
> +
> +maintainers:
> + - Akshat Chandra <notmissinge@xxxxxxxxx>
> +
> +description: |
Do not need '|' unless you need to preserve formatting.
> + Sensirion SGP41 indoor air quality sensor measuring raw VOC and NOx
> + signals over I2C.
> +
> +properties:
> + compatible:
> + const: sensirion,sgp41
> +
> + reg:
> + const: 0x59
> +
> + vdd-supply: true
> +
> +required:
> + - compatible
> + - reg
> + - vdd-supply
Missing blank line.
Best regards,
Krzysztof