Re: [PATCH v2 1/3] media: dt-bindings: Add Rockchip IEP2 deinterlacer

From: Krzysztof Kozlowski

Date: Mon Nov 16 2026 - 07:34:13 EST


On Sun, Nov 15, 2026 at 08:47:42AM +0000, Arun Iyengar wrote:
> Add a binding for the IEP2 deinterlacer of the RK3568 and RK3588 SoCs.
> It is a different block from the IEP of RK3228/RK3288/RK3328/RK3399,
> hence "iep2". The RK3588 block falls back to the RK3568 compatible:
> the vendor kernel drives both with one compatible ("rockchip,iep-v2")
> and one driver.

Honestly, last sentence is redundant. Vendor kernels do all sorts of
odd things. Qualcomm vendor kernel has 100 properties per device nodes,
each defining single piece of hardware or driver. Shall we ever mention
it? No, it's downstream choice, not relevant to here. If Rockchip
vendor kernel managed 100 devices with single compatible would that ever
mean anything to us? No.

>
> Clock and reset names follow the RGA binding. The resets are optional:
> the block has its own soft reset.
>
> Signed-off-by: Arun Iyengar <aiyengar1990@xxxxxxxxx>
> ---
> .../bindings/media/rockchip,rk3568-iep2.yaml | 95 ++++++++++++++++++++++
> MAINTAINERS | 7 ++
> 2 files changed, 102 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/rockchip,rk3568-iep2.yaml b/Documentation/devicetree/bindings/media/rockchip,rk3568-iep2.yaml
> new file mode 100644
> index 000000000000..0c7666de19f8
> --- /dev/null

...

> + deinterlace@fdbb0000 {
> + compatible = "rockchip,rk3588-iep2", "rockchip,rk3568-iep2";
> + reg = <0x0 0xfdbb0000 0x0 0x500>;
> + interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru ACLK_IEP2P0>, <&cru HCLK_IEP2P0>,
> + <&cru CLK_IEP2P0_CORE>;
> + clock-names = "aclk", "hclk", "sclk";
> + resets = <&cru SRST_A_IEP2P0>, <&cru SRST_H_IEP2P0>,
> + <&cru SRST_IEP2P0_CORE>;
> + reset-names = "axi", "ahb", "core";
> + power-domains = <&power RK3588_PD_VDPU>;
> + iommus = <&iep_mmu>;
> + };
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f4456f4589a1..b32b7eeb0a9e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -24285,6 +24285,13 @@ S: Maintained
> F: Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml
> F: sound/soc/rockchip/rockchip_i2s_tdm.*
>
> +ROCKCHIP IEP2 DEINTERLACER DRIVER
> +M: Arun Iyengar <aiyengar1990@xxxxxxxxx>
> +L: linux-media@xxxxxxxxxxxxxxx

You can drop the media, subsystem defines it. No need to grow more than
necessary.

> +L: linux-rockchip@xxxxxxxxxxxxxxxxxxx
> +S: Maintained
> +F: Documentation/devicetree/bindings/media/rockchip,rk3568-iep2.yaml

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Best regards,
Krzysztof