Re: [PATCH v2 1/2] spi: dt-bindings: sun6i: Allow Dual SPI and Quad SPI for the H616
From: Krzysztof Kozlowski
Date: Mon Nov 16 2026 - 07:46:05 EST
On Mon, Nov 16, 2026 at 05:55:25AM +0000, Arun Iyengar wrote:
> The H616 SPI controllers support dual and quad transfers (H616 user
> manual, SPI_BCC DRM and Quad_EN bits; only SPI0 has the WP/HOLD pins
> for quad). Allow them, as commit 743956bb9990 ("spi: dt-bindings:
> sun6i: Allow Dual SPI and Quad SPI for newer SoCs") did for the R329
Referencing other commit is here redundant. You document new hardware,
so why does it matter that some other commit did something for other
hardware?
You were already arguing you do not need a compatible. See writing
bindings first.
> and A523. The H616 keeps the H3 fallback.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
Best regards,
Krzysztof