Re: [PATCH 2/2] rtc: mt6397: provide the 32 kHz output as a clock

From: Lee Jones

Date: Mon Nov 16 2026 - 07:47:25 EST


On Fri, 13 Nov 2026, Ryan Brue wrote:

> On 11/13/26 12:50 PM, Lee Jones wrote:
> > On Sun, 01 Nov 2026, Ryan Brue wrote:
> >
> > > struct mtk_rtc_data {
> > > u32 wrtgr;
> > > + u32 con;
> > These are terrible variable names.
> >
> > The nomenclature should be self-describing.
>
> Hi Lee, two things:
>
> 1. I have a v2 out [1] from early November that fixed a null pointer
> dereference that Sashiko found. I can spin a v3 or resend v2 depending on
> the response to (2).

Happy with whatever makes sense.

> 2. would you like me to update wrtgr as well? I can add a patch to a v3 that
> changes that name in addition to con.

Yes please.

> [1] https://lore.kernel.org/all/20261102-rbrue-suez-upstreaming-mt6397-rtc-32k-v2-0-19ca72815374@xxxxxxxxx/
>
> Thanks for the review,
> Ryan Brue

--
Lee Jones