Re: [PATCH 3/5] s390/vmlogrdr: Replace get_zeroed_page() with kzalloc()

From: Heiko Carstens

Date: Mon Nov 16 2026 - 08:14:41 EST


On Sun, Nov 08, 2026 at 10:49:00AM +0200, Mike Rapoport (Microsoft) wrote:
> vmlogrdr_init() allocates the buffers used to receive z/VM system
> service records via IUCV.
>
> These buffers can be allocated with kmalloc() as there's nothing special
> about them to go directly to the page allocator.
>
> kmalloc() provides a better API that does not require ugly casts and
> kfree() does not need to know the size of the freed object.
>
> Performance difference between kmalloc() and __get_free_pages() is not
> measurable as both allocators take an object/page from a per-CPU list for
> fast path allocations.
>
> For the slow path the performance is anyway determined by the amount of
> reclaim involved rather than by what allocator is used.
>
> Replace use of get_zeroed_page() with kzalloc() and free_page() with
> kfree().
>
> Link: https://lore.kernel.org/all/635405e4-9423-4a25-a6e7-e03c8ea0bcbe@xxxxxxxxxx
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@xxxxxxxxxx>
> ---
> drivers/s390/char/vmlogrdr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Heiko Carstens <hca@xxxxxxxxxxxxx>