Re: [PATCH net-next v3 2/2] net: stmmac: dwmac-rk: Add RK3572 support

From: Andrew Lunn

Date: Mon Nov 16 2026 - 08:57:31 EST


> +static void rk3572_set_to_rgmii(struct rk_priv_data *bsp_priv,
> + int tx_delay, int rx_delay)
> +{
> + u32 val = GRF_FIELD(14, 8, rx_delay) | GRF_FIELD(6, 0, tx_delay) |
> + GRF_FIELD(15, 15, !!rx_delay) | GRF_FIELD(7, 7, !!tx_delay);
> +
> + if (bsp_priv->id == 1) {
> + regmap_write(bsp_priv->php_grf, RK3572_VCCIO0_3_VO_IOC_CON1, val);
> + regmap_write(bsp_priv->php_grf, RK3572_VCCIO5_6_IOC_MISC0, val);
> + } else {
> + regmap_write(bsp_priv->php_grf, RK3572_VCCIO1_2_4_VI_IOC_CON1, val);
> + }
> +}
> +
> +static const struct rk_gmac_ops rk3572_ops = {
> + .init = rk3572_init,
> + .set_to_rgmii = rk3572_set_to_rgmii,
> + .gmac_phy_intf_sel_mask = GENMASK_U16(11, 9),
> + .gmac_rmii_mode_mask = BIT_U16(3),
> + .clock.io_clksel_io_mask = BIT_U16(7),
> + .clock.gmii_clk_sel_mask = GENMASK_U16(6, 5),
> + .clock.rmii_clk_sel_mask = BIT_U16(5),
> + .clock.rmii_gate_en_mask = BIT_U16(4),
> + .supports_rmii = true,
> + .php_grf_required = true,
> + .regs_valid = true,
> + .regs = { 0x29d20000, 0x2a040000, 0 },
> +};

Just looking at this, it is not obvious that rx_delay and tx_delay are
actually not used.

Andrew