Re: [PATCH 2/2] gpu: nova-core: remove unnecessary firmware pin-init
From: Alexandre Courbot
Date: Mon Nov 16 2026 - 08:57:47 EST
On Mon Nov 16, 2026 at 9:29 PM JST, Danilo Krummrich wrote:
> On Mon Nov 16, 2026 at 5:02 AM CET, Alexandre Courbot wrote:
>>> + pub(crate) fn new(dev: &'a device::Device<device::Bound>, chipset: Chipset) -> Result<Self> {
>>
>> `GspFirmware` is 312 bytes, that's not enormous but that's also not
>> small... Shall we keep returning an `impl Pininit`?
>
> I considered that, but it's only ever constructed in Gsp::boot() and does not
> outlive boot(), so I think it should be fine.
Sgtm.
Reviewed-by: Alexandre Courbot <acourbot@xxxxxxxxxx>