Re: [PATCH net v3 2/2] selftests: net: veth: propagate bad-settings check failures to exit status
From: Tianyi Gao
Date: Mon Nov 16 2026 - 09:05:14 EST
On Mon, 16 Nov 2026 09:41:07 +0100 Omokefe Emmanuel Onanaroghene wrote:
> - echo "fail - set operation successful ?!?" || echo " ok "
> + { echo "fail - set operation successful ?!?"; ret=1; } || echo " ok "
Two small suggestions:
1. These lines are 85 columns wide, over the 80-column limit.
2. The style is inconsistent with the rest of the file. Other checks
use if/else instead of a "cmd && { ...; } || ..." chain.
Cheers,
Tianyi