Re: [PATCH net-next v2 08/10] net: dsa: realtek: rtl8365mb: program the PCP of untagged frames
From: Andrew Lunn
Date: Mon Nov 16 2026 - 09:06:31 EST
> Restoring the old PCP does not help here. A write can fail for two
> reasons. One is a register access the regmap configuration rejects;
> that is a driver bug and shows up on every call, not something to
> recover from at runtime. The other is an MDIO bus error, and then the
> restore goes over the same failing bus, and the state of the switch is
> unknown whatever the driver does. Reordering the writes does not help
> either: either order leaves one field new and one old on failure. So
> v3 keeps the code as it is.
The LLM often does comment about MDIO errors, but they pretty much
never happen, and there is no recovery. So i agree, this can be
ignored.
Andrew