Re: [PATCH net-next v6 2/7] dt-bindings: net: ftgmac100: Add AST2700 compatible
From: Andrew Lunn
Date: Mon Nov 16 2026 - 09:10:47 EST
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: aspeed,ast2700-mac
> > + then:
> > + required:
> > + - phy-mode
>
> [Severity: Medium]
> Is phy-mode really mandatory for every AST2700 MAC node? The binding
> also documents the use-ncsi boolean. That mode runs the NC-SI stack
> over RMII instead of talking to an MDIO PHY. The first example in this
> file sets use-ncsi and has no phy-mode property, and that is a valid
> setup on the earlier Aspeed parts.
This seems like a valid point. Maybe make it conditional like the
code, either phy-mode, or use-ncsi. Both or neither is invalid.
Andrew