Re: [RFC PATCH v7 00/29] Hierarchical Constant Bandwidth Server

From: Juri Lelli

Date: Mon Nov 16 2026 - 09:26:24 EST


Hello,

On 09/11/26 17:35, Yuri Andriaccio wrote:

...

> Version v7 introduces a lot of changes since v6. First off there have been a
> lot of bug fixes from the comments by the reviewers and the automated AI tool
> Sashiko, which surprisingly caught a lot of issues. Later, we've finally had
> time to add features which were planned a long time ago. The following are the
> most meaningful updates since v6 (the complete changelog can be found on the
> github readme):
> - Rebase to kernel version 7.4-rc1.
> - Address (most of) bugs as reported in the v6 reviews.
> - Introduce dl_freq_invariant flag for dl_servers.
> + Force fair/ext servers to be frequency/capacity invariant, while allow
> HCBS servers to scale their consumed runtime.
> + This enables capacity-aware bandwidth reservation also for HCBS.
> - Rework cgroup-v2 interface:
> + Rename cpu.rt.internal to cpu.rt.effective.local
> + Fix internal runtime rounding errors.
> - Update cgroup balance callbacks to allow balancing operation of multiple
> cgroups at the same time.
> - Allow unprivileged FIFO/RR tasks inside cgroups.
> - Allow HRTICK_DL for HCBS servers.
> - Integrate `cpu` and `cpuset` controllers.
> - Integrate HCBS with hotplug/hotunplug operations.
> - Introduce dl_server overrides (previously known as multi-runtime/multi-CPU).

...

> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
> Testing v7:
>
> The patchset has been tested with a suite of tests tailored to stress all the
> implemented functionalities.
> The tests are available at https://github.com/Yurand2000/HCBS-Test-Suite .
> Refer to the README of the repository for more details.
>
> Follow these steps to test HCBS v7:
> - Get the HCBS patch up and running. Any kernel/disto should work effortlessly.
> - Get, compile and _install_ the tests.
> - Run the `go_rt.sh` script to set the frequency of the CPUs to a fixed value
> and disable hyperthreading and power saving features.
> - Run the `run_tests.sh full` script, to run the whole test suite.
>
> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

I think Sashiko already commented about it, but I had to apply the
following to make the series compile with clang.

BTW, since you already received comments from Tejun and Sashiko also
raised lots of stuff to look at, shall I wait for a v8 before engaging
as well, so that you don't get overwhelmed? :)

Thanks for your work!
Juri
---
kernel/sched/rt.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index 8702d0e0c4e3c..c9c8752a61532 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -3113,11 +3113,13 @@ static int sched_rt_global_validate(void)

DEFINE_MUTEX(sched_rt_handler_mutex);

-void sched_rt_handler_mutex_lock() {
+void sched_rt_handler_mutex_lock(void)
+{
mutex_lock(&sched_rt_handler_mutex);
}

-void sched_rt_handler_mutex_unlock() {
+void sched_rt_handler_mutex_unlock(void)
+{
mutex_unlock(&sched_rt_handler_mutex);
}