Re: [PATCH mm-unstable 1/1] fs/proc/task_mmu: advance seq_file position on interrupted VMA lookup
From: Lorenzo Stoakes (ARM)
Date: Mon Nov 16 2026 - 09:37:36 EST
On Thu, Nov 12, 2026 at 10:01:01PM +0800, Adrian Huang (Lenovo) wrote:
> Commit 5631da56c9a8 ("fs/proc/task_mmu: read proc/pid/maps under
> per-vma lock") introduced the possibility of returning -EINTR
> from proc_get_vma() when the VMA lookup is interrupted.
>
> When this happens in m_next(), proc_get_vma() returns an error
> pointer without updating the position index. Consequently,
> seq_read_iter() reports:
>
> seq_file: buggy .next function m_next did not update position index
What does seq_read_iter() 'reporting' something mean? It feels like you're
trying to make this into something bigger than it is.
What you mean to say is a rate-limited pr_info() output occurs, and when a
process that _has received a fatal signal_ (!!) somehow continues long
enough to try to output more data, you get an pr_info().
The relevant code from seq_read_iter():
if (pos == m->index) {
pr_info_ratelimited("buggy .next function %ps did not update position index\n",
m->op->next);
m->index++;
}
Anyway you should mention the fatal signal requirement clearly.
>
> The above buggy message is reproduced by the following command:
>
> # stress-ng --vma 0 -t 60
OK I could reproduce the output locally. It seems that this run results in
fatal signals being sent to the processes triggering this output.
> Update the position index when VMA lookup fails, as required by
> the seq_file interface. Also save the original position in
> priv->last_pos so that subsequent iteration can restart from
> the correct address without skipping or repeating a VMA.
We don't really care about skipping or repeating a VMA for a process that's
about to die :)
We may as well do this but better to just hoist that to share code.
>
> Fixes: 5631da56c9a8 ("fs/proc/task_mmu: read proc/pid/maps under per-vma lock")
This isn't really a bug, it's really cosmetic to be honest. So not sure if
we need a cc: stable hmm.
> Signed-off-by: Adrian Huang (Lenovo) <adrianhuang0701@xxxxxxxxx>
See attached suggested patch that makes the comment sane + hoists the shared
bit (dropping a silly existing comment).
With that and an updated commit message should be ok.
> ---
> fs/proc/task_mmu.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
> index 22361607020d..164b4efc5e09 100644
> --- a/fs/proc/task_mmu.c
> +++ b/fs/proc/task_mmu.c
> @@ -221,6 +221,16 @@ static struct vm_area_struct *proc_get_vma(struct seq_file *m, loff_t *ppos)
> if (PTR_ERR(vma) == -EAGAIN && fallback_to_mmap_lock(priv, *ppos))
> goto retry;
>
> + /*
> + * seq_file checks that the position advanced before it looks at
> + * the returned pointer, so an error return that leaves *ppos
> + * alone is reported as a buggy ->next. Advance it, and keep
> + * last_pos at the pending position so m_start() would resume
> + * the lookup from there.
> + */
We don't want (schloppy?) comments that go into painful detail about super
specific elements of the code.
This is asking for bit rot and is too complicated to be in any way useful.
> + priv->last_pos = *ppos;
This is duplicative with code below and strictly not necessary for the fix,
better to hoist I think.
> + (*ppos)++;
> +
> return vma;
> }
>
> --
> 2.43.0
>
Suggested:
----8<----