Re: [PATCH rtw-next v3 1/2] wifi: rtw88: 8822c: fix out-of-bounds access in cck_pd_set
From: Luka Gejak
Date: Mon Nov 16 2026 - 09:49:21 EST
On November 15, 2026 9:18:25 PM GMT+01:00, Zeshan Ahmed Nobin
<zeshanahmednobin@xxxxxxxxx> wrote:
>rtw8822c_phy_cck_pd_set() reads the bandwidth from a 2-bit register
>field and uses it as the first index into dm_info->cck_pd_lv[], which
>only has entries for 20 and 40 MHz.
>
>When the chip stops responding on the PCIe bus, register reads return
>all ones and bw becomes 3. The function then reads cck_pd_lv[3][nrx],
>past the end of the array. If that byte differs from new_lvl, it calls
>rtw8822c_phy_cck_pd_set_reg(), which rejects bw with WARN_ON(), and
>then writes new_lvl to cck_pd_lv[3][nrx] anyway. UBSAN reports the
>first of these accesses as:
>
> UBSAN: array-index-out-of-bounds in .../rtw88/rtw8822c.c:4407:21
> index 3 is out of range for type 'u8 [2][4]'
> Workqueue: phy0 rtw_watch_dog_work [rtw88_core]
> Call Trace:
> <TASK>
> __ubsan_handle_out_of_bounds+0xdd/0x120
> rtw8822c_phy_cck_pd_set+0x33c/0x510 [rtw88_8822c]
> rtw_phy_dynamic_mechanism+0x310/0x330 [rtw88_core]
> rtw_watch_dog_work+0x217/0x330 [rtw88_core]
>
>The driver doesn't need to read the bandwidth from the chip:
>rtw_set_channel() stores it in rtwdev->hal.current_band_width and
>programs the same value into the chip. Use the stored value. CCK PD
>only runs on 2.4 GHz, where the bandwidth is 20 or 40 MHz, so the
>stored value is always a valid index.
>
>On PCIe, a chip that stops responding still returns nrx = 3; the next
>patch handles nrx values without CCK PD registers.
>
>The fix and this message were drafted with an AI coding assistant
>(Claude Opus 5.5 by Anthropic), then reviewed and tested by the
>submitter.
>
>Fixes: 479c4ee931a6 ("rtw88: add dynamic cck pd mechanism")
>Cc: stable@xxxxxxxxxxxxxxx
>Suggested-by: Luka Gejak <luka.gejak@xxxxxxxxx>
>Signed-off-by: Zeshan Ahmed Nobin <zeshanahmednobin@xxxxxxxxx>
>---
>
Looks good to me,
Reviewed-by: Luka Gejak <luka.gejak@xxxxxxxxx>
Best regards,
Luka Gejak