Re: [PATCH v3 2/2] perf/core: Disable context fast-swap for sigtrap events

From: Tengda Wu

Date: Mon Nov 16 2026 - 10:00:33 EST




On 2026/11/16 18:17, Sebastian Andrzej Siewior wrote:
> On 2026-11-05 09:30:44 [+0000], Tengda Wu wrote:
>> perf_sigtrap() contains:
>>
>> WARN_ON_ONCE(event->ctx->task != current)
>>
>> The warning assumes that an event's ctx->task always matches the task
>> that ends up running the pending task_work. That assumption can be
>> broken by the context fast-swap path.
>>
>> The failure sequence is:
>>
>> 1. A -> B switch, perf_event_context_sched_out() takes the fast path
>> and does WRITE_ONCE(ctx->task, next) / WRITE_ONCE(next_ctx->task, task).
>> An NMI then hits while the context is swapped, and
>> __perf_event_overflow() queues pending task_work on the *current*
>> task (A), even though the event now belongs to B's swapped-in
>> context view.
>>
>> 2. B -> A switch. Because A now has pending task_work,
>> nr_no_switch_fast is non-zero, so the slow path is taken and
>> ctx->task is *not* swapped back.
>>
>> 3. A returns to user mode, task_work runs perf_pending_task() ->
>> perf_sigtrap(), and event->ctx->task no longer equals current,
>> tripping the WARN_ON_ONCE().
>>
>> The context fast-swap path was already excluded for events that need
>> stable task association (inherit + sample read). sigtrap events have
>> the same requirement: the SIGTRAP is targeted at ctx->task and must not
>> be delivered after ctx->task has been swapped to another task.
>>
>> Fix this by also excluding events with attr->sigtrap from the fast-swap
>> path, i.e. bump nr_no_switch_fast for sigtrap events in
>> list_add_event()/list_del_event(), and update the comment describing
>> the invariant accordingly.
>>
>> Fixes: c5d93d23a260 ("perf: Enqueue SIGTRAP always via task_work.")
>> Signed-off-by: Tengda Wu <wutengda@xxxxxxxxxxxxxxx>
>> ---
>> include/linux/perf_event.h | 6 ++----
>> kernel/events/core.c | 9 +++++++--
>> 2 files changed, 9 insertions(+), 6 deletions(-)
>>
>> --- a/kernel/events/core.c
>> +++ b/kernel/events/core.c
>> @@ -1999,7 +1999,7 @@ list_add_event(struct perf_event *event, struct perf_event_context *ctx)
>> ctx->nr_user++;
>> if (event->attr.inherit_stat)
>> ctx->nr_stat++;
>> - if (has_inherit_and_sample_read(&event->attr))
>> + if (has_inherit_and_sample_read(&event->attr) || event->attr.sigtrap)
>> local_inc(&ctx->nr_no_switch_fast);
>
> This is already done in __perf_event_overflow() while the event is
> added. You are saying this is not enough/ too late. This is required to
> be done/ disabled once the event is created if I understand it.
> If so, do we need to keep this nr_no_switch_fast inc/dec in
> __perf_event_overflow() and perf_pending_task()?
>
> Sebastian

Indeed, the now-redundant nr_no_switch_fast updates in __perf_event_overflow()
and perf_pending_task() can be removed.

Thanks,
Tengda