[PATCH] media: synopsys: hdmirx: move the reset bulk data out of the driver data

From: Sascha Hauer

Date: Mon Nov 16 2026 - 10:07:09 EST


devm_reset_control_bulk_get_exclusive() keeps a pointer to the bulk data
it is handed and releases the controls through it when devres is torn
down. Since the driver data is freed from the v4l2_device release
callback, remove() and the probe error paths may free it before that
happens: on every unbind without an open file descriptor, and on every
probe that fails after hdmirx_parse_dt(), in practice a deferral.
devm_reset_control_bulk_release() then reads the controls from freed
memory. KASAN reports the use-after-free, the controls stay claimed, and
the deferred probe fails for good with -EBUSY on the exclusive get.

Give the array an allocation of its own with devm_kcalloc(), so it lives
exactly as long as devres needs it.

Fixes: 03ec4aa9817b ("media: synopsys: hdmirx: free the driver data when the last user is gone")
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
---
Hans, this fixes the patch you applied from v3 of the hdmirx bridge
series. Sashiko pointed out the use-after-free on v3, and the fix was
meant to go into v4 of that patch. If you can still replace 03ec4aa9817b
in your tree, please squash this into it; otherwise it applies on top.

The remaining patches of the series will follow as v4, rebased onto this
and with the v4l2-compliance output you asked for.

The fix was developed with the help of an AI coding assistant (Claude),
which also drafted this message.
---
drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
index a241761b1bcd9..8a5304603c00d 100644
--- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
+++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
@@ -144,7 +144,8 @@ struct snps_hdmirx_dev {
struct mutex phy_rw_lock; /* to protect phy r/w configuration */
struct mutex stream_lock; /* to lock video stream capture */
struct mutex work_lock; /* to lock the critical section of hotplug event */
- struct reset_control_bulk_data resets[HDMIRX_NUM_RST];
+ /* devres may release these after the driver data is freed */
+ struct reset_control_bulk_data *resets;
struct clk_bulk_data *clks;
struct regmap *grf;
struct regmap *vo1_grf;
@@ -2296,6 +2297,12 @@ static int hdmirx_parse_dt(struct snps_hdmirx_dev *hdmirx_dev)
}
}

+ hdmirx_dev->resets = devm_kcalloc(dev, HDMIRX_NUM_RST,
+ sizeof(*hdmirx_dev->resets),
+ GFP_KERNEL);
+ if (!hdmirx_dev->resets)
+ return -ENOMEM;
+
hdmirx_dev->resets[HDMIRX_RST_A].id = "axi";
hdmirx_dev->resets[HDMIRX_RST_P].id = "apb";
hdmirx_dev->resets[HDMIRX_RST_REF].id = "ref";

---
base-commit: 48fe5a7834cc10081887d7bcd9ff0a4cadc3fa8c
change-id: 20261116-hdmirx-resets-uaf-d6792101954b

Best regards,
--
Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>