Re: [PATCH v6 04/12] drivers/ata: Stop using 32-bit MSR interfaces

From: Damien Le Moal

Date: Mon Nov 16 2026 - 10:12:08 EST


On 11/16/26 07:02, Juergen Gross wrote:
> The 32-bit MSR interfaces rdmsr() and wrmsr() are planned to be
> removed. Use the related 64-bit variants instead.
>
> In drivers/ata/pata_cs5536.c don't redefine rdmsr() and wrmsr() as
> empty macros for avoiding misuse, but guard the affected code via
> a simple #ifdef.
>
> Switch pio_cmd_timings[] to a u32 type array in order to avoid a cast
> to u32 when constructing final MSR values.
>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> Acked-by: Niklas Cassel <cassel@xxxxxxxxxx>

Please change the patch title to be:

ata: pata_cs553X: Stop using 32-bit MSR interfaces

Other than that,

Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx>

--
Damien Le Moal
Western Digital Research