Re: [PATCH 1/3] powercap: arm_scmi: Fix potential stale zones after a skipped leaf
From: Sudeep Holla
Date: Mon Nov 16 2026 - 10:25:54 EST
On Sun, Nov 15, 2026 at 11:05:44AM +0000, Cristian Marussi wrote:
> From: Guangshuo Li <liguangshuo@xxxxxxxxxxxxxxx>
>
> scmi_zones_register() skips leaf zones that cannot be registered, but
> returns the last leaf error when that leaf ends the traversal. Probe
> then fails without unregistering the successfully registered zones,
> whose private data is device-managed.
>
> Return success after completing the traversal. Keep the existing error
> return and full rollback for a failed non-leaf zone.
>
> This issue was found by our static analysis tool under development.
>
> Fixes: 3e767d6850f8 ("powercap: arm_scmi: Remove recursion while parsing zones")
> Cc: "Rafael J. Wysocki" <rafael@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
Reviewed-by: Sudeep Holla <sudeep.holla@xxxxxxxxxx>
> Signed-off-by: Guangshuo Li <liguangshuo@xxxxxxxxxxxxxxx>
> Reviewed-by: Cristian Marussi <cristian.marussi@xxxxxxx>
> Signed-off-by: Cristian Marussi <cristian.marussi@xxxxxxx>
I may be wrong but sign-off when you repost means you are agreeing with
the change and hence review tag is not needed ?
--
Regards,
Sudeep