Re: [PATCH rtw-next v5 06/10] wifi: rtw89: transmit frames from monitor interfaces
From: Enver Ikromov
Date: Mon Nov 16 2026 - 10:32:30 EST
On Mon, Nov 16, 2026 at 01:35:42AM +0000, Ping-Ke Shih wrote:
> > for injected data frames whose addr2
> > matches an active interface, via wake_tx_queue and
> > rtw89_core_txq_push().
>
> How can I reproduce this? I setup wlan0 + mon0 (with UP state), and
> use your script to inject packet with wlan0's mac address, it still
> goes via rtw89_ops_tx().
That only happened when wlan0 was associated to an AP and the injected
data frame's addr1 matched the peer STA (so ieee80211_lookup_ra_sta()
found the STA TXQ).
> The flag IEEE80211_CONF_MONITOR is cleared if both wlan0 + mon0 are UP.
> Do you actually need that? I have no good idea now. Can we just focus
> on single monitor case? Or just avoid crash from concurrency
> combination.
Agreed. Focusing on the single monitor interface case (and just
avoiding the crash on wlan0 + mon0 via patch 1) makes the series much
simpler. In single monitor mode mac80211 already validates
skb_headlen() in ieee80211_monitor_start_xmit() and passes the virtual
monitor vif to rtw89_ops_tx(), so this entire patch is unnecessary. I
will drop patch 06/10 completely in v6.
Thanks,
Enver