Re: [PATCH rtw-next v5 07/10] wifi: rtw89: send injected control frames through the management path

From: Enver Ikromov

Date: Mon Nov 16 2026 - 10:33:23 EST


On Mon, Nov 16, 2026 at 02:14:36AM +0000, Ping-Ke Shih wrote:
> Did you encounter real problem if CTS/RST goes via AC queue?
> I just don't want much conditions in data path.

I tested injecting 16-byte RTS (checking live over-the-air CTS replies
from an AP) as well as 10-byte ACK and 10-byte CTS via the AC queue
without changing rtw89_core_get_tx_type(): it works identically to the
management queue (23/25 CTS replies on 2.4 GHz and 25/25 on 5 GHz, with
no errors). So routing control frames to the management path is not
needed.

> Did you actually see driver sends control frames generated by mac80211?
> If so, when and how?

Only via ieee80211_send_bar() (BlockAckReq when a TX BA session flushes
or tears down).

> If my thought is correct, here can just
>
> if (ieee80211_is_ctl(hdr->frame_control))
> seq = 0;
> else
> seq = (le16_to_cpu(hdr->seq_ctrl) & IEEE80211_SCTL_SEQ) >> 4;

Agreed, I will drop the rtw89_core_get_tx_type() change and keep only
this 4-line seq = 0 check in v6.

Thanks,
Enver