Re: [PATCH rtw-next v5 09/10] wifi: rtw89: honor ASSIGN_SEQ, retries, and NO_ACK for injected frames

From: Enver Ikromov

Date: Mon Nov 16 2026 - 10:34:19 EST


On Mon, Nov 16, 2026 at 03:00:10AM +0000, Ping-Ke Shih wrote:
> No need to describe driver behavior.
> [...]
> > + desc_info->upd_wlan_hdr = false;
>
> Does it need to update this?

Not needed in single monitor mode (desc_info->mlo is false, so
upd_wlan_hdr is already false). Will drop.

> First line of block comment should be empty.
>
> But this comment is not necessary. The code explains itself.
> [...]
> You have set
> hw->max_rate_tries = RTW89_TX_DATA_CNT_LMT_MAX;
>
> Is it still necessary to have umin()?
> [...]
> I think the maximum standard VHT MCS rate is 9. Just use 9 inline.
> [...]
> > - } else {
> > + } else if (!(info->flags & IEEE80211_TX_CTL_NO_ACK) ||
> > + tx_status != RTW89_TX_RETRY_LIMIT) {
>
> Will it be a problem without this change?
> This branch is only to sum internal counters of the driver.

Agreed on all points. Checking ieee80211_parse_tx_radiotap() in
mac80211 also shows that rates[0].count is already clamped to
hw->max_rate_tries, HT/VHT/legacy rate indices are already range
checked there, and IEEE80211_TX_RC_USE_RTS_CTS is never set for
injected frames.

In v6 I will shorten the commit message and trim this patch down to
just clearing hw_ssn_sel/hw_seq_mode when ASSIGN_SEQ is unset, handling
NO_ACK, and honoring rates[0].count with max_rate_tries = 63 (dropping
upd_wlan_hdr, RTS/CTS, rate clamping, comments, and the pci.c change).

Thanks,
Enver