Re: [PATCH rtw-next v5 10/10] wifi: rtw89: restore channel when leaving idle on non-chanctx devices

From: Enver Ikromov

Date: Mon Nov 16 2026 - 10:35:31 EST


On Mon, Nov 16, 2026 at 07:56:25AM +0000, Zong-Zhe Yang wrote:
> I think you can just call rtw89_set_channel() in rtw89_ops_start().
> And since this is more like an improvement to UX, please place this
> patch before the patches you add features.

I checked rtw89_ops_start() against ieee80211_do_open(): mac80211 calls
drv_start() before ieee80211_add_virtual_monitor() and
drv_add_interface(), so rtwdev->pure_monitor_mode_vif is still NULL
during rtw89_ops_start() and rtw89_chip_rfk_channel_for_pure_mon_vif()
would be skipped (and on chanctx devices rtw89_set_channel() would run
a second time right after when the chanctx is assigned).

Setting changed |= IEEE80211_CONF_CHANGE_CHANNEL in rtw89_ops_config()
for no_chanctx as Ping-Ke suggested runs after pure_monitor_mode_vif is
set and calls rtw89_set_channel() once. I will move this patch before
the feature patches in v6 as you suggested.

Thanks,
Enver