Re: [PATCH v8 00/12] nvmem: Add Raspberry Pi OTP nvmem driver
From: Srinivas Kandagatla
Date: Mon Nov 16 2026 - 10:56:26 EST
On 11/10/26 4:33 PM, Gregor Herburger wrote:
> Hi,
>
> This series adds support for the Raspberry Pis OTP registers. The
> Raspberry Pi has one or more OTP regions. These registers are accessible
> through the firmware. Add a driver for it and add updates the devicetree
> for the Raspberry Pi 5.
What is the merge strategy for this series?
Am happy to pick up non-dt patches 1-6/12 and 12/12.
let me know other wise.
--srini
>
> ---
> Changes in v8:
> - Really rebase to v7.4-rc2
> - Add a patch to reorder rpi_firmware_property_tag enum
> - Link to v7: https://patch.msgid.link/20261110-rpi-otp-driver-v7-0-2345d0ee65f0@xxxxxxxxxxxxx
>
> Changes in v7:
> - Rebase to v7.4-rc2
> - Added Patch to register rtc driver by soc enum from drvdata
> - Link to v6: https://patch.msgid.link/20260522-rpi-otp-driver-v6-0-b0eac97d1428@xxxxxxxxxxxxx
>
> Changes in v6:
> - Use %pe in dev_err
> - Include <linux/slab.h> to fix build on arm
> - Add arm defconfigs: multi_v7_defconfig and bcm2835_defconfig
> - Reword commit messages
> - Link to v5: https://patch.msgid.link/20260520-rpi-otp-driver-v5-0-b26e5908eeac@xxxxxxxxxxxxx
>
> Changes in v5:
> - Move alignment check to nvmem core
> - Use IS_REACHABLE to simplify Kconfig
> - use root_only for private driver
> - Add driver as module to arch64 defconfig
> - Use MODULE_DEVICE_TABLE
> - Remove some unused attributes, fix typos, minor fixups
> - Link to v4: https://patch.msgid.link/20260508-rpi-otp-driver-v4-0-cf8d725d8821@xxxxxxxxxxxxx
>
> Changes in v4:
> - Additional patch to drop unnecessary select schema
> - fix dt-bindings
> - use __counted_by_le
> - additional alignment check in read/write callbacks
> - Link to v3: https://patch.msgid.link/20260506-rpi-otp-driver-v3-0-294602663695@xxxxxxxxxxxxx
>
> Changes in v3:
> - dts: add "raspberrypi,bcm2835-firmware" as fallback and fix dt-bindings
> - Fix Kconfig depends
> - Changed firmware data fields to __le32
> - Add MODULE_ALIAS
> - Link to v2: https://patch.msgid.link/20260505-rpi-otp-driver-v2-0-e9176ec72837@xxxxxxxxxxxxx
>
> Changes in v2:
> - register nvmem driver from firmware driver and drop firmware sub nodes
> - Use struct_size and __counted_by for dynamic array
> - Drop unneeded comment in Kconfig
> - Use NVMEM_DEVID_NONE
> - Use kzalloc
> - Update module description
> - Link to v1: https://patch.msgid.link/20260408-rpi-otp-driver-v1-0-e02d1dbe6008@xxxxxxxxxxxxx
>
> ---
> Gregor Herburger (12):
> firmware: raspberrypi: reorder rpi_firmware_property_tag enum
> soc: bcm2835: Use IS_REACHABLE for function declaration
> nvmem: core: Enforce stride and alignment checks for nvmem_device functions
> dt-bindings: raspberrypi,bcm2835-firmware: Add bcm2712-firmware compatible
> nvmem: Add the Raspberry Pi OTP driver
> firmware: raspberrypi: register nvmem driver
> arm64: dts: broadcom: bcm2712: add raspberrypi,bcm2712-firmware compatible
> dt-bindings: raspberrypi,bcm2835-firmware: Drop unnecessary select
> arm64: defconfig: Enable the raspberrypi otp driver as module
> ARM: bcm2835_defconfig: Enable the raspberrypi otp driver as module
> ARM: multi_v7_defconfig: Enable the raspberrypi otp driver as module
> firmware: raspberrypi: use drvdata to register rtc driver
>
> .../arm/bcm/raspberrypi,bcm2835-firmware.yaml | 20 ++--
> arch/arm/configs/bcm2835_defconfig | 2 +
> arch/arm/configs/multi_v7_defconfig | 1 +
> .../boot/dts/broadcom/bcm2712-rpi-5-b-base.dtsi | 4 +-
> arch/arm64/configs/defconfig | 1 +
> drivers/firmware/raspberrypi.c | 62 +++++++++-
> drivers/nvmem/Kconfig | 11 ++
> drivers/nvmem/Makefile | 1 +
> drivers/nvmem/core.c | 12 ++
> drivers/nvmem/raspberrypi-otp.c | 131 +++++++++++++++++++++
> include/soc/bcm2835/raspberrypi-firmware.h | 37 ++++--
> 11 files changed, 256 insertions(+), 26 deletions(-)
> ---
> base-commit: b3dfbde62cf1981c4638939c159dfd087b7a72e9
> change-id: 20260408-rpi-otp-driver-75fce1dcff7d
>
> Best regards,
> --
> Gregor Herburger <gregor.herburger@xxxxxxxxxxxxx>
>