Re: [PATCH] mm/hmm: reject shadow-stack mappings

From: Gregory Price (Meta)

Date: Mon Nov 16 2026 - 11:09:54 EST


On 2026-11-16 10:48 +1100, Alistair Popple wrote:
> On 2026-11-14 at 22:11 +1100, "David Hildenbrand (Arm)" <david@xxxxxxxxxx> wrote...
> > It's writable by the hardware, that's what matters to core-mm, for example, when
> > it comes to things like fork(), mproetect() etc.
>
> Except they're not universally writable by HW, after all _PAGE_RW = 0. So
> pte_write() is documented to return if it is logically writable, which of course
> is what hmm_range_fault() also needs for certain values of "logic" :-)
>
> So it's easy to see how this is confusing and got missed. Anyway this fix looks
> good:
>
> Reviewed-by: Alistair Popple <apopple@xxxxxxxxxx>
>

Thank's Alistair!

--
~Gregory