Re: [PATCH v3 0/3] nvme-tcp: consume TLS records without application data on a live queue
From: Keith Busch
Date: Mon Nov 16 2026 - 11:19:02 EST
On Thu, 12 Nov 2026 16:13:33 -0500, Martin Belanger via B4 Relay wrote:
> After the TLS handshake, a peer may send records that carry no
> application data: a NewSessionTicket, a KeyUpdate or an alert.
> tls_sw_read_sock() cannot pass such a record to nvme_tcp_recv_skb().
> It returns -EINVAL and leaves the record at the head of the receive
> queue. Since commit 288cfa187208 ("nvme-tcp: start error recovery when
> read_sock fails"), nvme-tcp then starts error recovery, and the
> controller reconnects.
>
> [...]
Thanks, applied to nvme-7.4.
[1/3] nvme-tcp: use an aligned buffer for the TLS record type
commit: 1193566c35ead643e954ff8356bb54b1cd78378a
[2/3] nvme-tcp: move the TLS record read loop into a helper
commit: 76afef5e29221e68f9a19df767f94b092c31e974
[3/3] nvme-tcp: consume TLS records without application data
commit: 687e743e4089b2a854982b321cb2d681ae5d6136
--
Keith Busch <kbusch@xxxxxxxxxx>