Re: [PATCH 3/3] mm/vmscan: consolidate promo vs. high watermark checks
From: Joshua Hahn
Date: Mon Nov 16 2026 - 12:22:44 EST
On Fri, Nov 13, 2026 at 05:49:17PM -0800, SJ Park wrote:
> On Fri, 13 Nov 2026 15:52:36 -0800 Joshua Hahn <joshua.hahnjy@xxxxxxxxx> wrote:
>
> > There are three sites which all check the watermark that kswapd reclaims
> > zones up to, which is the promo watermark when NUMA balancing memory
> > tiering is enabled, and the high watermark otherwise.
> >
> > Consolidate the patern into a helper function. While at it, remove the
>
> Nit of nit. s/patern/pattern/ ?
Thanks for your review on the series, SJ! And yes, thank you for the
catch, totally missed that : -)
Andrew / David -- could you help me to fix this in the commit message?
I'd be happy to send a new version as well, whichever you prefer!
Thanks! Have a great day SJ,
Joshua
> > include for <linux/sched/sysctl.h> in mm/page_alloc.c now that the
> > dependency on sysctl_numa_balancing_mode has been abstracted into
> > vmscan code.
> >
> > No functional changes intended.
>
> Looks good to me.
>
> >
> > Signed-off-by: Joshua Hahn <joshua.hahnjy@xxxxxxxxx>
>
> Reviewed-by: SJ Park <sj@xxxxxxxxxx>
>
>
> Thanks,
> SJ
>
> [...]