Re: [PATCH 13/35] iio: accel: bma220: use default_trigger

From: Petre Rodan

Date: Mon Nov 16 2026 - 12:27:49 EST



Hello Jonathan,

On Mon, Nov 16, 2026 at 01:48:01AM +0000, Jonathan Cameron wrote:
> From: Jonathan Cameron <jonathan.cameron@xxxxxxxxxxxxxxxx>
>
> Set indio_dev->default_trigger rather than taking a reference to the
> trigger in probe(). The IIO core now takes the reference during
> iio_device_register(), so it is not leaked if probe() fails after
> the trigger is set up. Whilst this patch closes the specific
> bug, it also makes the ordering less fragile going forwards.
>
> Fixes: b7e17ca10793 ("iio: accel: bma220: add interrupt trigger")
> Signed-off-by: Jonathan Cameron <jonathan.cameron@xxxxxxxxxxxxxxxx>
> ---
> drivers/iio/accel/bma220_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/bma220_core.c b/drivers/iio/accel/bma220_core.c
> index b83abfdd84fd..23eff578158c 100644
> --- a/drivers/iio/accel/bma220_core.c
> +++ b/drivers/iio/accel/bma220_core.c
> @@ -539,7 +539,7 @@ int bma220_common_probe(struct device *dev, struct regmap *regmap, int irq)
> if (ret)
> return dev_err_probe(dev, ret,
> "iio trigger register fail\n");
> - indio_dev->trig = iio_trigger_get(data->trig);
> + indio_dev->default_trigger = data->trig;
> ret = devm_request_threaded_irq(dev, irq, NULL,
> &bma220_irq_handler, IRQF_ONESHOT,
> indio_dev->name, indio_dev);
> --
> 2.56.1
>

passes all my unit tests on both i2c and spi sensors, thanks for the patch.

Tested-by: Petre Rodan <petre.rodan@xxxxxxxxxxxxxxx>

best regards,
peter

Attachment: signature.asc
Description: PGP signature