Re: [PATCH v3 5/8] dt-bindings: timer: Add MIPS P8700 ACLINT MTIMER

From: Conor Dooley

Date: Mon Nov 16 2026 - 12:30:37 EST


On Mon, Nov 16, 2026 at 12:55:12PM +0100, Aleksa Paunovic via B4 Relay wrote:
> From: Aleksa Paunovic <aleksa.paunovic@xxxxxxxxxxxxx>
>
> Document the MIPS P8700 ACLINT MTIMER.
> Extend support for both mtimecmp and mtime registers
> within the ACLINT MTIMER, identified via reg-names.
>
> Signed-off-by: Aleksa Paunovic <aleksa.paunovic@xxxxxxxxxxxxx>

Perhaps worth mentioning that we are doing this this way because opensbi
expects this behaviour, as does u-boot, for the riscv,aclint-mtimer
compatible and we wish to align this device with it.

Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
pw-bot: not-applicable

(If I end up applying this, I will amend the commit message)

Cheers,
Conor.

> ---
> .../bindings/timer/thead,c900-aclint-mtimer.yaml | 37 ++++++++++++++++++++++
> 1 file changed, 37 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/timer/thead,c900-aclint-mtimer.yaml b/Documentation/devicetree/bindings/timer/thead,c900-aclint-mtimer.yaml
> index cf7c82e980f674afcf59fc726742dc4f49c1a820..a5ebe04ade9ed61c8beac5017aab94ab12afa9ea 100644
> --- a/Documentation/devicetree/bindings/timer/thead,c900-aclint-mtimer.yaml
> +++ b/Documentation/devicetree/bindings/timer/thead,c900-aclint-mtimer.yaml
> @@ -21,13 +21,19 @@ properties:
> - enum:
> - anlogic,dr1v90-aclint-mtimer
> - const: nuclei,ux900-aclint-mtimer
> + - const: mips,p8700-aclint-mtimer
>
> reg:
> + minItems: 1
> items:
> + - description: MTIME Registers, or MTIMECMP Registers if only one
> + region is present
> - description: MTIMECMP Registers
>
> reg-names:
> + minItems: 1
> items:
> + - enum: [ mtime, mtimecmp ]
> - const: mtimecmp
>
> interrupts-extended:
> @@ -42,6 +48,26 @@ required:
> - reg-names
> - interrupts-extended
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: mips,p8700-aclint-mtimer
> + then:
> + properties:
> + reg:
> + minItems: 2
> + reg-names:
> + minItems: 2
> + else:
> + properties:
> + reg:
> + maxItems: 1
> + reg-names:
> + items:
> + - const: mtimecmp
> +
> examples:
> - |
> timer@ac000000 {
> @@ -53,4 +79,15 @@ examples:
> reg = <0xac000000 0x00010000>;
> reg-names = "mtimecmp";
> };
> +
> + - |
> + timer@16108050 {
> + compatible = "mips,p8700-aclint-mtimer";
> + reg = <0x16108050 0x8>, <0x16154000 0x7ff8>;
> + reg-names = "mtime", "mtimecmp";
> + interrupts-extended = <&cpu1intc 7>,
> + <&cpu2intc 7>,
> + <&cpu3intc 7>,
> + <&cpu4intc 7>;
> + };
> ...
>
> --
> 2.43.0
>
>

Attachment: signature.asc
Description: PGP signature