Re: [PATCH] i2c: imx: acknowledge the count byte of an atomic block read

From: Stefan Eichenberger

Date: Mon Nov 16 2026 - 12:59:42 EST


On Mon, Nov 16, 2026 at 01:27:06PM +0100, Mehmet Fide wrote:
> From: Mehmet Fide <mehmet.fide@xxxxxxxxxxxxxxxxxx>
>
> i2c_smbus_xfer_emulated() sends the read message of an SMBus block read
> with a length of 1 and I2C_M_RECV_LEN. i2c_imx_prepare_read() clears
> I2CR_TXAK only for a message longer than one byte, so the atomic read
> does not acknowledge the count byte. The target stops sending, the rest
> of the block is read as 0xff and the transfer reports success.
>
> The test for I2C_M_RECV_LEN was dropped when the read was split into
> i2c_imx_prepare_read() and its callers. Commit a5d0b9e32745 ("i2c: imx:
> fix emulated smbus block read") added it back to the interrupt driven
> read only. The DMA read never gets an I2C_M_RECV_LEN message.
>
> Fixes: b460b15b3cc2 ("i2c: imx: separate atomic, dma and non-dma use case")
> Cc: stable@xxxxxxxxxxxxxxx # v6.13+
> Signed-off-by: Mehmet Fide <mehmet.fide@xxxxxxxxxxxxxxxxxx>
> ---
>
> Notes:
> Reported by the Sashiko review of "i2c: imx: test the block read flag of
> the message that is read":
> https://sashiko.dev/#/bug/linux-09e3015b-fc03-4410-809b-82964cdfac9c
>
> Tested on a Colibri VF50 on the Iris carrier, kernel at this base, with
> the M41T0 RTC at 0x68. The core takes the atomic path only after
> SYSTEM_RUNNING, so a test-only hook called xfer_atomic() with interrupts
> disabled, with the two messages that i2c_smbus_xfer_emulated() builds
> for a block read. Register 0x04 (0x13) as count byte: without the patch
> 0x13 and then 0xff (50 of 50, return 2); with it the next registers,
> the same bytes as the interrupt driven read (50 of 50). With a count
> byte of 1 (register 0x05): 01 ff before, 01 01 after (50 of 50 each).
>
> drivers/i2c/busses/i2c-imx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index ccf08cd63151..1a3fc245d6ba 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -1283,7 +1283,7 @@ static int i2c_imx_prepare_read(struct imx_i2c_struct *i2c_imx,
> * Reset the I2CR_TXAK flag initially for SMBus block read since the
> * length is unknown
> */
> - if (msgs->len - 1)
> + if ((msgs->len - 1) || (msgs->flags & I2C_M_RECV_LEN))
> temp &= ~I2CR_TXAK;
> if (use_dma)
> temp |= I2CR_DMAEN;
>
> base-commit: 25e7ab89f4774b0f842cee0e8a20c11f755924d5
> --
> 2.56.0

Thanks for the fix.

Reviewed-by: Stefan Eichenberger <eichest@xxxxxxxxx>