Re: [PATCH 12/19] dt-bindings: pinctrl: add the Allwinner V861 pin controllers
From: Conor Dooley
Date: Mon Nov 16 2026 - 13:35:46 EST
On Sat, Nov 14, 2026 at 06:33:38AM +0800, Han Gao via B4 Relay wrote:
> From: Han Gao <gaohan@xxxxxxxxxxx>
>
> The V861 main and always-on pin controllers follow the A523 binding.
> The always-on one has a single interrupt bank, so also allow a single
> debounce value.
>
> Signed-off-by: Han Gao <gaohan@xxxxxxxxxxx>
> ---
> .../pinctrl/allwinner,sun55i-a523-pinctrl.yaml | 31 +++++++++++++++++++---
> 1 file changed, 28 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/allwinner,sun55i-a523-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/allwinner,sun55i-a523-pinctrl.yaml
> index d7d0ba32ced4..3c2924df17b9 100644
> --- a/Documentation/devicetree/bindings/pinctrl/allwinner,sun55i-a523-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/allwinner,sun55i-a523-pinctrl.yaml
> @@ -4,7 +4,7 @@
> $id: http://devicetree.org/schemas/pinctrl/allwinner,sun55i-a523-pinctrl.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> -title: Allwinner A523 & A733 Pin Controller
> +title: Allwinner A523, A733 & V861 Pin Controller
>
> maintainers:
> - Andre Przywara <andre.przywara@xxxxxxx>
> @@ -26,6 +26,8 @@ properties:
>
> compatible:
> enum:
> + - allwinner,sun252i-v861-pinctrl
> + - allwinner,sun252i-v861-r-pinctrl
> - allwinner,sun55i-a523-pinctrl
> - allwinner,sun55i-a523-r-pinctrl
> - allwinner,sun60i-a733-pinctrl
> @@ -35,7 +37,7 @@ properties:
> maxItems: 1
>
> interrupts:
> - minItems: 2
> + minItems: 1
> maxItems: 11
> description:
> One interrupt per external interrupt bank supported on the
> @@ -62,7 +64,7 @@ properties:
> Debouncing periods in microseconds, one period per interrupt
> bank found in the controller
> $ref: /schemas/types.yaml#/definitions/uint32-array
> - minItems: 2
> + minItems: 1
You've lowered the constraints here, and while this is harmless that is
not apparent from the diff so please note it in your commit message.
Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
pw-bot: changes-requested
> maxItems: 11
>
> patternProperties:
> @@ -149,6 +151,29 @@ allOf:
> minItems: 2
> maxItems: 2
>
> + - if:
> + properties:
> + compatible:
> + const: allwinner,sun252i-v861-pinctrl
> + then:
> + properties:
> + interrupts:
> + minItems: 7
> + maxItems: 7
> + input-debounce:
> + maxItems: 7
> +
> + - if:
> + properties:
> + compatible:
> + const: allwinner,sun252i-v861-r-pinctrl
> + then:
> + properties:
> + interrupts:
> + maxItems: 1
> + input-debounce:
> + maxItems: 1
> +
> additionalProperties: false
>
> examples:
>
> --
> 2.55.0
>
>
Attachment:
signature.asc
Description: PGP signature