Re: [PATCH] sched/topology: Avoid unsequenced accesses to jiffies in sd_init()
From: Nick Desaulniers
Date: Mon Nov 16 2026 - 13:36:59 EST
On Sat, Nov 14, 2026 at 09:19:52PM -0700, Nathan Chancellor wrote:
> After a recent improvement in clang to warn on unsequenced accesses to
> volatile variables [1], an instance appears in sd_init(), which can
> break the build with CONFIG_WERROR=y / W=e:
>
> In file included from kernel/sched/build_utility.c:86:
> kernel/sched/topology.c:2008:29: error: unsequenced accesses to volatile qualified 'jiffies' [-Werror,-Wunsequenced]
> 1998 | .last_balance = jiffies,
> | ~~~~~~~
> 1999 | .balance_interval = sd_weight,
> 2000 |
> 2001 | /* 50% success rate */
> 2002 | .newidle_call = 512,
> 2003 | .newidle_success = 256,
> 2004 | .newidle_ratio = 512,
> 2005 | .newidle_stamp = now,
> 2006 |
> 2007 | .max_newidle_lb_cost = 0,
> 2008 | .last_decay_max_lb_cost = jiffies,
> | ^
>
> Per C11 5.1.2.3.2, accessing a volatile object is a side effect. Per C11
> 6.5.2, unsequenced side effects on the same scalar object are undefined
> behavior. Per C11 6.7.9.23, the evaluation of the initialization list
> expressions in a designated initializer is indeterminately sequenced
> relative to each other, meaning any side effects in the initialization
> list are unsequenced.
>
> Move the initialization of these fields outside the designated
> initializer to place sequence points between the accesses to jiffies,
> clearing up the warning.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Closes: https://github.com/ClangBuiltLinux/linux/issues/2190
> Fixes: 2b4cfe64dee0 ("sched/numa: Initialize newidle balance stats in sd_numa_init()")
> Link: https://github.com/llvm/llvm-project/commit/955715460eaf9188c241c74750637fc82dfcc423 [1]
> Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx>
> ---
> kernel/sched/topology.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
> index 99878da03bce..f5975079f453 100644
> --- a/kernel/sched/topology.c
> +++ b/kernel/sched/topology.c
> @@ -1994,7 +1994,6 @@ sd_init(struct sched_domain_topology_level *tl,
> | sd_flags
> ,
>
> - .last_balance = jiffies,
> .balance_interval = sd_weight,
>
> /* 50% success rate */
> @@ -2004,10 +2003,11 @@ sd_init(struct sched_domain_topology_level *tl,
> .newidle_stamp = now,
>
> .max_newidle_lb_cost = 0,
> - .last_decay_max_lb_cost = jiffies,
> .child = child,
> .name = tl->name,
> };
> + sd->last_balance = jiffies;
> + sd->last_decay_max_lb_cost = jiffies;
This pattern is going to wind up with two volatile (expensive) accesses,
(with potentially different values) rather than one access and the same
value by accessing `jiffies` once then storing the result in a temporary
local (before the designated initializer), then using that to initialize
the two fields in the designated initializer.
Example: https://godbolt.org/z/h8bvvKK6j
>
> WARN_ONCE((sd->flags & (SD_SHARE_CPUCAPACITY | SD_ASYM_CPUCAPACITY)) ==
> (SD_SHARE_CPUCAPACITY | SD_ASYM_CPUCAPACITY),
>
> ---
> base-commit: d7e670601af6c564ccf6d3b2ddf70ee4f41a6d1c
> base-tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> change-id: 20261114-topology-wunsequenced-18f1d3b9167c
>
> Best regards,
> --
> Cheers,
> Nathan
>