[PATCH v6 33/37] sched/deadline: Check the runtime of a task whose parameters change
From: Mathieu Desnoyers
Date: Mon Nov 16 2026 - 14:07:50 EST
Commit 40767b0dc768 ("sched/deadline: Fix deadline parameter
modification handling") lets new parameters take effect at the next
period. So sched_setattr() cannot give a task a fresh runtime.
But admission control counts the new bandwidth at once. When a task
shrinks its reservation, the runtime left from the old one is not
checked against the new one. A comment in sched_dl_overflow() names
the gap: the old bandwidth should stay counted until the 0-lag time.
So a running task can shrink its reservation, and still run on the old
one. Other tasks can meanwhile be admitted into the bandwidth it gave
back. On v7.4-rc1, a task of 50ms every 100ms changed to 10ms every
100ms. It ran 39ms of the next 100ms.
Fix this by applying the wakeup rule after a change of parameters, as
the previous patch does for a task that enters the class.
__setparam_dl() marks a change of the runtime, the deadline or the
period. The next enqueue then calls update_dl_entity(). It starts a new
period, or reduces the runtime of a constrained task, if the runtime
left does not fit. The task gets no more than a wakeup would give it.
A larger reservation still takes effect at the next period.
The enqueue flags cannot tell a change of parameters: a cgroup move
also uses ENQUEUE_MOVE. Without the mark, a task that waited behind
others could fail the check, and get a later deadline for no reason.
The change_running_new_params case of deadline_bw_test, added later in
this series, tests this. It fails on v7.4-rc1 and passes with this
patch.
Fixes: 40767b0dc768 ("sched/deadline: Fix deadline parameter modification handling")
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>
Cc: stable@xxxxxxxxxxxxxxx
---
include/linux/sched.h | 5 +++++
kernel/sched/deadline.c | 20 +++++++++++++++-----
2 files changed, 20 insertions(+), 5 deletions(-)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 2f2f59402f09..f40abe5b9ace 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -715,6 +715,10 @@ struct sched_dl_entity {
* @dl_bw_oncpu tells if the this_bw of a runqueue counts the task's
* @dl_bw: add_rq_bw() and sub_rq_bw() set and clear it, under that
* runqueue's lock. Not for servers, which keep @dl_bw_attached.
+ *
+ * @dl_new_params tells if sched_setattr() changed the runtime, the
+ * deadline or the period. The next enqueue checks the runtime left
+ * against them, and clears it.
*/
unsigned int dl_throttled : 1;
unsigned int dl_yielded : 1;
@@ -729,6 +733,7 @@ struct sched_dl_entity {
unsigned int dl_defer_idle : 1;
unsigned int dl_bw_attached : 1;
unsigned int dl_bw_oncpu : 1;
+ unsigned int dl_new_params : 1;
/*
* Bandwidth enforcement timer. Each -deadline task has its
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index b47c13c8714d..3b62ee43c209 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -2674,7 +2674,10 @@ static void __dequeue_dl_entity(struct sched_dl_entity *dl_se)
static void
enqueue_dl_entity(struct sched_dl_entity *dl_se, int flags)
{
+ bool new_params = dl_se->dl_new_params;
+
WARN_ON_ONCE(on_dl_rq(dl_se));
+ dl_se->dl_new_params = 0;
update_stats_enqueue_dl(dl_rq_of_se(dl_se), dl_se, flags);
@@ -2723,12 +2726,13 @@ enqueue_dl_entity(struct sched_dl_entity *dl_se, int flags)
update_dl_entity(dl_se);
} else if (flags & ENQUEUE_REPLENISH) {
replenish_dl_entity(dl_se);
- } else if ((flags & ENQUEUE_CLASS) && !is_dl_boosted(dl_se)) {
+ } else if (((flags & ENQUEUE_CLASS) || new_params) &&
+ !is_dl_boosted(dl_se)) {
/*
- * The task enters the class runnable. It may come back before
- * its deadline, with the runtime left from older parameters.
- * Check that runtime against the new parameters, as a wakeup
- * does.
+ * The task enters the class, or its parameters change, while
+ * it is runnable. It may have runtime left from older
+ * parameters. Check that runtime against the new parameters,
+ * as a wakeup does.
*/
update_dl_entity(dl_se);
} else if ((flags & ENQUEUE_MOVE) &&
@@ -4696,6 +4700,11 @@ void __setparam_dl(struct task_struct *p, const struct sched_attr *attr)
u64 period = attr->sched_period ?: attr->sched_deadline;
bool held;
+ if (attr->sched_runtime != dl_se->dl_runtime ||
+ attr->sched_deadline != dl_se->dl_deadline ||
+ period != dl_se->dl_period)
+ dl_se->dl_new_params = 1;
+
/*
* Change the bandwidth that the runqueue counts here, with the
* parameters. A task that priority inheritance boosted into the
@@ -4828,6 +4837,7 @@ static void __dl_clear_params(struct sched_dl_entity *dl_se)
dl_se->dl_defer_running = 0;
dl_se->dl_defer_armed = 0;
dl_se->dl_bw_oncpu = 0;
+ dl_se->dl_new_params = 0;
#ifdef CONFIG_RT_MUTEXES
dl_se->pi_se = dl_se;
--
2.47.3