Re: [PATCH v7 17/19] fs/resctrl: Control visibility of global per-CPU kernel mode group files
From: Babu Moger
Date: Mon Nov 16 2026 - 15:11:44 EST
On 11/11/26 16:44, Babu Moger wrote:
The kmode_cpus and kmode_cpus_list files are specific to the global per-CPU
kernel mode. These files are created in a hidden state when an rdtgroup is
created.
Introduce resctrl_kmode_global_files_show() to control the visibility of
these files for individual resource groups. Show the files only for the
group backing the active global per-CPU kernel mode and hide them for all
other groups.
Suggested-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>
Signed-off-by: Babu Moger <babu.moger@xxxxxxx>
---
v7: Updated the prototype rdtgroup_kmode_global_files_show().
Moved the patch after both rdtgroup_kmode_global_activate() and
rdtgroup_kmode_global_deactivate() is Introduced, so the change is
symmetrical.
Updated the changelog.
v6: Helper named for the global per-CPU files instead of unhiding every
hidden file on the group.
https://lore.kernel.org/lkml/34aa4824-810b-4c81-8188-f2f37e1dc277@xxxxxxxxx/
---
fs/resctrl/rdtgroup.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/fs/resctrl/rdtgroup.c b/fs/resctrl/rdtgroup.c
index 1ad169e714a4..86bd6a66812b 100644
--- a/fs/resctrl/rdtgroup.c
+++ b/fs/resctrl/rdtgroup.c
@@ -1136,6 +1136,24 @@ static int resctrl_kernel_mode_show(struct kernfs_open_file *of,
return 0;
}
+/* Show or hide kmode_cpus and kmode_cpus_list on @kn. */
+static void resctrl_kmode_global_files_show(struct rdtgroup *rdtgrp, bool show)
+{
+ struct kernfs_node *kn_file;
+
+ kn_file = kernfs_find_and_get(rdtgrp->kn, "kmode_cpus");
+ if (kn_file) {
+ kernfs_show(kn_file, show);
+ kernfs_put(kn_file);
+ }
+
+ kn_file = kernfs_find_and_get(rdtgrp->kn, "kmode_cpus_list");
+ if (kn_file) {
+ kernfs_show(kn_file, show);
+ kernfs_put(kn_file);
+ }
+}
+
/*
* resctrl_kmode_global_online_cpu() - Program kernel mode association for @cpu
* @cpu: CPU that has just been brought online
@@ -1194,6 +1212,7 @@ static void rdtgroup_kmode_global_deactivate(struct rdtgroup *rdtgrp)
resctrl_configure_kmode_global(&rdtgrp->kmode_cpu_mask, rdtgrp, false);
cpumask_clear(&rdtgrp->kmode_cpu_mask);
+ resctrl_kmode_global_files_show(rdtgrp, false);
resctrl_kmode.rdtgrp = NULL;
resctrl_kmode.active = RESCTRL_INHERIT_USER;
@@ -1214,6 +1233,7 @@ static void rdtgroup_kmode_global_activate(struct rdtgroup *rdtgrp,
cpumask_copy(&rdtgrp->kmode_cpu_mask, cpu_online_mask);
resctrl_configure_kmode_global(&rdtgrp->kmode_cpu_mask, rdtgrp, true);
+ resctrl_kmode_global_files_show(rdtgrp, true);
}
static int resctrl_kmode_parse_state(char *val, enum kmode_state *state)
Sashiko reported:
https://sashiko.dev/#/patchset/cover.1794437052.git.babu.moger%40amd.com?part=17
=============================================================================
commit 05ab3c952d1bee6b5476ced04f03000037d907a0
Author: Babu Moger <babu.moger@xxxxxxx>
fs/resctrl: Control visibility of global per-CPU kernel mode group files
This commit introduces a helper to show or hide the kmode_cpus and
kmode_cpus_list kernfs files when a resource group activates or deactivates
global per-CPU kernel mode.
diff --git a/fs/resctrl/rdtgroup.c b/fs/resctrl/rdtgroup.ckernfs_open_file *of,
index 68e72afada85a..e2a996102f7e1 100644
--- a/fs/resctrl/rdtgroup.c
+++ b/fs/resctrl/rdtgroup.c
@@ -1136,6 +1136,24 @@ static int resctrl_kernel_mode_show(struct
return 0;bool show)
}
+/* Show or hide kmode_cpus and kmode_cpus_list on @kn. */
+static void resctrl_kmode_global_files_show(struct rdtgroup *rdtgrp,
+{association for @cpu
+ struct kernfs_node *kn_file;
+
+ kn_file = kernfs_find_and_get(rdtgrp->kn, "kmode_cpus");
+ if (kn_file) {
+ kernfs_show(kn_file, show);
+ kernfs_put(kn_file);
+ }
+
+ kn_file = kernfs_find_and_get(rdtgrp->kn, "kmode_cpus_list");
+ if (kn_file) {
+ kernfs_show(kn_file, show);
+ kernfs_put(kn_file);
+ }
+}
+
/*
* resctrl_kmode_global_online_cpu() - Program kernel mode
* @cpu: CPU that has just been brought onlinerdtgroup_kmode_global_deactivate(struct rdtgroup *rdtgrp)
@@ -1194,6 +1212,7 @@ static void
rdtgroup_kmode_global_activate(struct rdtgroup *rdtgrp,
resctrl_configure_kmode_global(&rdtgrp->kmode_cpu_mask, rdtgrp, false);
cpumask_clear(&rdtgrp->kmode_cpu_mask);
+ resctrl_kmode_global_files_show(rdtgrp, false);
resctrl_kmode.rdtgrp = NULL;
resctrl_kmode.active = RESCTRL_INHERIT_USER;
@@ -1214,6 +1233,7 @@ static void
cpumask_copy(&rdtgrp->kmode_cpu_mask, cpu_online_mask);
resctrl_configure_kmode_global(&rdtgrp->kmode_cpu_mask, rdtgrp, true);
+ resctrl_kmode_global_files_show(rdtgrp, true);
}
static int resctrl_kmode_parse_state(char *val, enum kmode_state *state)
As reported by Reinette Chatre on v6 [1], should
resctrl_kmode_global_files_show() be renamed to
rdtgroup_kmode_global_files_show() to match its struct rdtgroup parameter, rdtgroup_kmode_global_activate(), and rdtgroup_kmode_global_deactivate() (as noted in the v7 patch changelog)? The comment above the helper also still refers to @kn instead of @rdtgrp.
In addition, the commit message still omits the requested context explaining why kmode_cpus and kmode_cpus_list are specific to global per-CPU kernel mode (used by user space for per-CPU enable and disable of the mode) and why they are created hidden (a resource group can only be assigned to global per-CPU kernel mode after creation via a separate resctrl file).
[1] https://lore.kernel.org/r/c600a240-ed11-4e31-b3c3-779f01175f28@xxxxxxxxx
=========================================================================
My bad. Yes. Will fix the naming to rdtgroup_kmode_global_files_show() and also will fix the comment about @kn
Thanks
Babu