Re: [PATCH v2 1/2] dmaengine: pl08x: Release the reset before reading registers

From: Frank Li

Date: Mon Nov 16 2026 - 15:24:20 EST


On Fri, Nov 06, 2026 at 03:25:58PM +0800, David Yang wrote:
> [You don't often get email from mmyangfl@xxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> amba_read_periphid() happens to release the reset. A node that carries
> arm,primecell-periphid never reaches it. Take the reset shared and
> release it ourselves.
>
> Signed-off-by: David Yang <mmyangfl@xxxxxxxxx>
> ---

Reviewed-by: Frank Li <Frank.Li@xxxxxxx>

> drivers/dma/amba-pl08x.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
> index 543c2eb8cfa8..9f5e4f5fb877 100644
> --- a/drivers/dma/amba-pl08x.c
> +++ b/drivers/dma/amba-pl08x.c
> @@ -75,6 +75,7 @@
> #include <linux/of.h>
> #include <linux/of_dma.h>
> #include <linux/pm_runtime.h>
> +#include <linux/reset.h>
> #include <linux/seq_file.h>
> #include <linux/slab.h>
> #include <linux/amba/pl080.h>
> @@ -2695,6 +2696,7 @@ static int pl08x_probe(struct amba_device *adev, const struct amba_id *id)
> struct pl08x_driver_data *pl08x;
> struct vendor_data *vd = id->data;
> struct device_node *np = adev->dev.of_node;
> + struct reset_control *rst;
> u32 tsfr_size;
> int ret = 0;
> int i;
> @@ -2725,6 +2727,13 @@ static int pl08x_probe(struct amba_device *adev, const struct amba_id *id)
> goto out_no_ioremap;
> }
>
> + /* Release the reset before reading registers */
> + rst = devm_reset_control_get_optional_shared_deasserted(&adev->dev, NULL);
> + if (IS_ERR(rst)) {
> + ret = PTR_ERR(rst);
> + goto out_no_platdata;
> + }
> +
> if (vd->ftdmac020) {
> u32 val;
>
> --
> 2.53.0
>