[PATCH v2 4/4] platform/x86: dell: dcdbas: Validate the WSMT buffer description
From: Rosen Penev
Date: Mon Nov 16 2026 - 15:41:13 EST
dcdbas_check_wsmt() takes the address and size of the firmware SMI
buffer from an SMBIOS OEM string or from an EPS table in the BIOS area,
and sets
smi_buf.size = remap_size - 8;
max_smi_data_buf_size = smi_buf.size;
without checking that remap_size covers the 8 byte semaphore. An OEM
string such as "30[addr;4]" would make the size wrap to almost 2^64,
and smi_data reads and writes could then access memory well past the
mapping.
check_eps_table() also accepts a table with length 0, since the
checksum of zero bytes is zero, and then trusts the rest of it.
No firmware is known to describe the buffer like this, so this is
hardening against malformed tables rather than a fix for a reported
problem. Reject buffers smaller than the semaphore, and EPS tables
shorter than struct smm_eps_table.
Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
---
drivers/platform/x86/dell/dcdbas.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/platform/x86/dell/dcdbas.c b/drivers/platform/x86/dell/dcdbas.c
index 0db278eed5d8..1e854f02e171 100644
--- a/drivers/platform/x86/dell/dcdbas.c
+++ b/drivers/platform/x86/dell/dcdbas.c
@@ -538,6 +538,9 @@ static inline struct smm_eps_table *check_eps_table(u8 *addr)
if (strncmp(eps->smm_comm_buff_anchor, SMM_EPS_SIG, 4) != 0)
return NULL;
+ if (eps->length < sizeof(*eps))
+ return NULL;
+
if (checksum(addr, eps->length) != 0)
return NULL;
@@ -598,6 +601,12 @@ static int dcdbas_check_wsmt(void)
dev_warn(&dcdbas_pdev->dev, "found WSMT, but buffer address is above 4GB\n");
return -EINVAL;
}
+ /* The first 8 bytes are a semaphore, not part of the data buffer */
+ if (remap_size < 8) {
+ dev_warn(&dcdbas_pdev->dev, "found WSMT, but buffer size %llu is too small\n",
+ remap_size);
+ return -EINVAL;
+ }
/*
* Limit remap size to MAX_SMI_DATA_BUF_SIZE + 8 (since the first 8
* bytes are used for a semaphore, not the data buffer itself).
--
2.56.1