Re: [PATCH v2 2/2] ASoC: codecs: Add driver for Iron Device MA5311
From: Mark Brown
Date: Mon Nov 16 2026 - 15:44:31 EST
On Mon, Nov 16, 2026 at 04:57:11AM +0000, Hyun-Uk Son wrote:
> > > The values of these parameters in reg_defaults match the hardware
> > factory defaults.
> > Right, those are what the driver should nromally use.
> When you say "these parameters", are you referring specifically to
> gain-related settings, such as speaker volume, ADC gain, and PGA gain,
> or does this also include data path and output format settings?
Data path yes normally, but see below. Output format I guess so, though
that will essentially always be overwritten by the machine driver in the
normal course of affairs so it's rare to actually get the default
register values in practice.
> To make sure I understand your recommendation correctly, should
> the driver leave the data path and output format settings at their
> factory defaults as well?
> Or would it be acceptable to initialize the data path and output
> format settings while keeping sensitive parameters, such as speaker
> volume and ADC/PGA gain, at their factory defaults?
For the output format it's probably fine to change it, though like I say
I'm not sure that the setting would actually end up getting used. For
the data path usually we'd go with the hardware default unless there is
a very strong reason - for example drivers with DSP support might adjust
routing to/from the DSP as part of integrate handling for the DSP. If
it's just basic routing of the DAC to an ouput or whatever that's
usually left under user control.
Attachment:
signature.asc
Description: PGP signature